[PATCH] D27231: [PowerPC] Fix logic dealing with nop after calls (and tail-call eligibility)

[Kit Barton via Phabricator via llvm-commits]

kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.

Aside from some minor comments, this LGTM.



================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:4128
 
   // Check if Callee resides in the same module, because for now, PPC64 SVR4 ABI
   // (ELFv1/ELFv2) doesn't allow tail calls to a symbol resides in another
----------------
Probably should update this comment, since we're now checking for a section, not a module.
Also, I'm not sure if the link below is still relevant


================
Comment at: test/CodeGen/PowerPC/ppc64-blnop.ll:4
+; RUN: llc < %s -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu -mcpu=pwr8 | FileCheck %s
+; RUN: llc < %s -relocation-model=pic -verify-machineinstrs -mtriple=powerpc64-unknown-linux-gnu | FileCheck %s
+; RUN: llc < %s -function-sections -verify-machineinstrs -mtriple=powerpc64-unknown-linux-gnu | FileCheck %s -check-prefix=CHECK-FS
----------------
Do we also want to test -relocation-model=pic with -mtriple=powerpc64le-unknown-linux-gnu or will the code path be the same for powerpc64-unknown-linux-gnu?


================
Comment at: test/CodeGen/PowerPC/ppc64-blnop.ll:5
+; RUN: llc < %s -relocation-model=pic -verify-machineinstrs -mtriple=powerpc64-unknown-linux-gnu | FileCheck %s
+; RUN: llc < %s -function-sections -verify-machineinstrs -mtriple=powerpc64-unknown-linux-gnu | FileCheck %s -check-prefix=CHECK-FS
+
----------------
Same question here, but for function-sections


https://reviews.llvm.org/D27231