[PATCH] D26942: [SelectionDAG] getRawSubclassData should not return HasDebugValue.

[Justin Lebar via Phabricator via llvm-commits]

jlebar added inline comments.


================
Comment at: test/CodeGen/X86/fp128-g.ll:1
+; RUN: llc < %s -O2 -mtriple=x86_64-linux-android -mattr=+mmx | FileCheck %s --check-prefix=X64
+
----------------
jlebar wrote:
> jlebar wrote:
> > Please add a comment in this file indicating what it's testing.  This is important so that someone without context to this thread who hits a failure in this file can understand what is going on.
> This seems like a lot of testcase for this bug.  If all of these tests are necessary to cover cases here, please add comments explaining why they're different.
Is the debug metadata necessary in this test?


================
Comment at: test/CodeGen/X86/fp128-g.ll:23
+; X64-LABEL: test_return1:
+; X64:       .loc
+; X64:       movaps     (%rdi), %xmm0
----------------
Do we care about the .loc directives in the output?


https://reviews.llvm.org/D26942