[PATCH] D26730: AMDGPU/GlobalISel: Add support for simple shaders

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 30 15:27:52 PST 2016


qcolombet added a comment.

Hi Tom,

>From bringing up the GlobalISel infrastructure point of view, this looks good.
I would recommend to add test cases for the different passes using .mir instead of just having the checks for full pipeline (.ll -> asm).

Cheers,
-Quentin



================
Comment at: lib/Target/AMDGPU/AMDGPUCallLowering.cpp:88
+  // FIXME: We need to handle sign/zero extend
+  MIRBuilder.buildLoad(DstReg, PtrReg, *MMO);
+}
----------------
I would add a boolean and return false when we encounter such case. At least an assert seems in order :).


https://reviews.llvm.org/D26730





More information about the llvm-commits mailing list