[PATCH] D27234: [libFuzzer] Diff 4 - Split FuzzerUtil implementation for Posix and Windows.

Marcos Pividori via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 30 14:53:23 PST 2016


mpividori added inline comments.


================
Comment at: lib/Fuzzer/FuzzerUtil.cpp:199
+int NumberOfCpuCores() {
+  unsigned N = std::thread::hardware_concurrency();
+  if (!N) {
----------------
zturner wrote:
> I noticed that in the `SleepSeconds` function, there is a comment that they couldn't use stl because they wanted to avoid coverage of instrumented libc++.  You might wait for comments from kcc@ about whether this is relevant here as well.  If so, we might need to go back to pure C implementations for each platform.
@kcc what do you think about this?


Repository:
  rL LLVM

https://reviews.llvm.org/D27234





More information about the llvm-commits mailing list