[PATCH] D27170: Abstract almost all DwarfDebug out of the classes in DIE.cpp.

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 30 14:36:39 PST 2016


clayborg updated this revision to Diff 79819.
clayborg added a comment.

Address Adrian's comments from email by making DIE just have:

  class DIE {
    const DIEUnit *getUnit() const;
    const DIE *getUnitDie() const;
  };

And skip the "OrNull" variants. Also added a "expected a unit TAG" to the assert in the DIEUnit constructor that checks the incoming dwarf Tag.


https://reviews.llvm.org/D27170

Files:
  include/llvm/CodeGen/DIE.h
  include/llvm/DebugInfo/DWARF/DWARFDebugInfoEntry.h
  lib/CodeGen/AsmPrinter/DIE.cpp
  lib/CodeGen/AsmPrinter/DwarfAccelTable.cpp
  lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
  lib/CodeGen/AsmPrinter/DwarfCompileUnit.h
  lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  lib/CodeGen/AsmPrinter/DwarfDebug.h
  lib/CodeGen/AsmPrinter/DwarfFile.cpp
  lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  lib/CodeGen/AsmPrinter/DwarfUnit.h
  tools/dsymutil/DwarfLinker.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27170.79819.patch
Type: text/x-patch
Size: 35169 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161130/13ae0f95/attachment.bin>


More information about the llvm-commits mailing list