[PATCH] D27191: TII: add hook getInstrOperandImmValue.

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added inline comments.


================
Comment at: include/llvm/Target/TargetInstrInfo.h:1144
+                                       const MachineOperand &MO,
+                                       int64_t &Val) const {
+    return false;
----------------
MI is probably useless given it is accessible through MO.getParent(), unless it represents something else and in that case it must be documented.


================
Comment at: include/llvm/Target/TargetInstrInfo.h:1144
+                                       const MachineOperand &MO,
+                                       int64_t &Val) const {
+    return false;
----------------
qcolombet wrote:
> MI is probably useless given it is accessible through MO.getParent(), unless it represents something else and in that case it must be documented.
Val should probably be an APInt.


================
Comment at: include/llvm/Target/TargetInstrInfo.h:1144
+                                       const MachineOperand &MO,
+                                       int64_t &Val) const {
+    return false;
----------------
qcolombet wrote:
> qcolombet wrote:
> > MI is probably useless given it is accessible through MO.getParent(), unless it represents something else and in that case it must be documented.
> Val should probably be an APInt.
If this is a compile time known constant, why this is not directly MO_Immediate?
What am I saying is in which cases do we need that API?


https://reviews.llvm.org/D27191