[PATCH] D27273: Fix module map to create a module for the configured header Config/abi-breaking.h

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini created this revision.
mehdi_amini added reviewers: rsmith, bruno.
mehdi_amini added subscribers: llvm-commits, aprantl, dexonsmith.

A client of a header that relies on ABI breaking should get the macro
exported there.
Before this, the unittest for Support/Error including Support/Error.h
didn't get the macro exported by the Support module, because the
latter only re-export its submodules and included module, not
textual headers.

Hopefully, it'll also fix the build with local submodule visibility,
since the LLVM_Utils contains two submodules: ADT and Support. They
both include abi-breaking.h that defines a symbol. The textual
inclusion lead to a double definition of the symbol which broke
the parent module.


https://reviews.llvm.org/D27273

Files:
  llvm/include/llvm/module.modulemap.build


Index: llvm/include/llvm/module.modulemap.build
===================================================================
--- llvm/include/llvm/module.modulemap.build
+++ llvm/include/llvm/module.modulemap.build
@@ -3,3 +3,7 @@
   header "Support/DataTypes.h"
   export *
 }
+module LLVM_Config_gen {
+  header "Config/abi-breaking.h"
+  export *
+}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27273.79785.patch
Type: text/x-patch
Size: 344 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161130/12a785ef/attachment.bin>