[PATCH] D27272: AMDGPU/SI: Don't move copies of immediates to the VALU

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIFixSGPRCopies.cpp:319-320
+  case AMDGPU::V_MOV_B32_e64:
+    if (TII->hasModifiersSet(*MoveImm, AMDGPU::OpName::src0_modifiers))
+      return false;
+    // fall-through
----------------
I think this should be unreachable since we never emit this. I'm not sure the modifiers even work, so I don't think there's any reason to ever use this


================
Comment at: lib/Target/AMDGPU/SIFixSGPRCopies.cpp:370-371
+            MI.addImplicitDefUseOperands(MF);
+            MI.setDesc(TII->get(SMovOp));
+            break;
+          }
----------------
This will leave behind the implicit exec use


https://reviews.llvm.org/D27272