[PATCH] D27230: [libFuzzer] Diff 2 - Separate FuzzerDef.h in appropriate header files.

Marcos Pividori via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 30 09:29:53 PST 2016


mpividori added a comment.

@kcc , I separated the header file because it is better for code organization. Separating the functionalities in different logic units makes the code easier to understand and modify. So, each implementation only includes the interface of the unit that it needs to access, not all the declarations in one header file.
If we have only one header file like `FuzzerDefs.h`, when we need to look at the implementation of particular function, we don't have any idea in which file was implemented.  Also, all implementations files include all the declarations in FuzzerDefs, so it is not clear which is the actual relation between the different implementations.


Repository:
  rL LLVM

https://reviews.llvm.org/D27230





More information about the llvm-commits mailing list