[PATCH] D27249: [LoopVectorize] Use OpenMP vector routines.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: lib/Analysis/TargetLibraryInfo.cpp:1193
       compareWithScalarFnName);
-  return I != VectorDescs.end() && StringRef(I->ScalarFnName) == funcName;
+  //  return I != VectorDescs.end() && StringRef(I->ScalarFnName) == funcName;
+  if (I != VectorDescs.end())
----------------
Can this be removed?


================
Comment at: lib/Analysis/TargetLibraryInfo.cpp:1342
+
+bool TargetLibraryInfoImpl::isValidSignature(Type *Ty, FunctionType *&FTy) {
+  if (!Ty->isPointerTy())
----------------
It looks like the FTy argument is assigned to (line 1346) before it is used (line 1348). Is this intentional?


https://reviews.llvm.org/D27249