[PATCH] D27052: [compiler-rt][asan] Fix overlaping parameters for memmove/memcpy on windows.

Anna Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 29 17:52:34 PST 2016

zaks.anna added inline comments.

Comment at: lib/asan/asan_interceptors.cc:460
   ASAN_MEMCPY_IMPL(ctx, to, from, size);
filcab wrote:
> This part looks ok, of course.
Why do we need "!SANITIZER_MAC"? Wouldn't just calling PLATFORM_HAS_DIFFERENT_MEMCPY_AND_MEMMOVE work on the Mac? It's defined as :
bool PlatformHasDifferentMemcpyAndMemmove() {
  // On OS X 10.7 memcpy() and memmove() are both resolved
  // into memmove$VARIANT$sse42.
  // See also https://github.com/google/sanitizers/issues/34.
  // TODO(glider): need to check dynamically that memcpy() and memmove() are
  // actually the same function.
  return GetMacosVersion() == MACOS_VERSION_SNOW_LEOPARD;


More information about the llvm-commits mailing list