[PATCH] D26020: [XRay][compiler-rt][x86_64] Define a tail exit trampoline.

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added inline comments.


================
Comment at: compiler-rt/trunk/lib/xray/xray_trampoline_x86_64.S:147
+	movl	%r10d, %edi
+	movl	$1, %esi
+	callq	*%rax
----------------
rSerge wrote:
> Shouldn't here be `$2`, because `enum XRayEntryType { ENTRY = 0, EXIT = 1, TAIL = 2 };` and it's tail exit?
I thought about it, but as documented we don't want to introduce a new type yet (i.e. keep it simple as entry, exit only). Updating the format version allows us to introduce things like tail exits, exception exits, and other kinds of exit conditions (and maybe even different entry types too in case of, say, coroutines).


Repository:
  rL LLVM

https://reviews.llvm.org/D26020