[PATCH] D27179: LibFuzzer - Implement timers for Windows and improve synchronization.

[Marcos Pividori via Phabricator via llvm-commits]

mpividori added inline comments.


================
Comment at: lib/Fuzzer/FuzzerUtilWindows.cpp:38
+      if (HandlerOpt.sigsegv_cb)
+        HandlerOpt.sigsegv_cb();
       break;
----------------
amccarth wrote:
> I'm not sure what these callbacks may be doing in lib fuzzer.  Be aware that exception handlers cannot acquire any synchronization objects and cannot allocate memory, presumably because that could cause a deadlock.
> 
> https://msdn.microsoft.com/en-us/library/windows/desktop/ms681419(v=vs.85).aspx
@amccarth, thanks for your comments.
Yes, in fact all that callbacks call `Fuzzer::CrashCallback()` which doesn't consider the synchronization lock, as I mentioned before.


Repository:
  rL LLVM

https://reviews.llvm.org/D27179