[PATCH] D26855: New unsafe-fp-math implementation for X86 target

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 29 13:22:38 PST 2016


spatel added a comment.

In https://reviews.llvm.org/D26855#606635, @avt77 wrote:

> The new reciprocal implementation is done on more than 97%: we still don't have public tests but the code changes are almost completed. Please review and send me your comments.


I applied the patch to trunk, but every example that I tried after that crashed:
Assertion failed: (i < getNumOperands() && "getOperand() out of range!"), function getOperand, file llvm/include/llvm/CodeGen/MachineInstr.h, line 280.

Is it correct that this patch will allow us to remove 'fake' subtarget features like FeatureFastScalarFSQRT / FeatureFastVectorFSQRT ?


https://reviews.llvm.org/D26855





More information about the llvm-commits mailing list