[PATCH] D24699: [asan] Allow re-exec in instrumented unit tests on Darwin (fix unit tests on macOS <=10.10)

Filipe Cabecinhas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 29 09:40:43 PST 2016


filcab added a comment.

IIUC, `ReexecDisabled` being `false` on newer systems will just make us hit `DyldNeedsEnvVariable()` on `MaybeReexec()` which will return `false` (on systems where we'd "prefer" to have `ReexecDisabled` be `true`), hence we'll just be removing the library path from `DYLD_INSERT_VARIABLES` env var (if it's there).

If that's correct, then can we use the same trick as `DyldNeedsEnvVariable` for `ReexecDisabled`? Or am I making these two to be the same issue when they aren't?


https://reviews.llvm.org/D24699





More information about the llvm-commits mailing list