[PATCH] D27200: [ELF] - Do not create 4gb output when -obinary -Ttext and -omagic used together.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 29 08:00:19 PST 2016


grimar added a comment.

In https://reviews.llvm.org/D27200#607883, @ruiu wrote:

> Why are we creating program headers for --oformat=binary in the first place?


I think we always create them.
That true for obinary or case when we exclude them later with script:

  Out<ELFT>::ElfHeader = make<OutputSectionBase>("", 0, SHF_ALLOC);
  Out<ELFT>::ElfHeader->Size = sizeof(Elf_Ehdr);
  Out<ELFT>::ProgramHeaders = make<OutputSectionBase>("", 0, SHF_ALLOC);
  Out<ELFT>::ProgramHeaders->updateAlignment(sizeof(uintX_t));

We just do not always add them to output sections.


https://reviews.llvm.org/D27200





More information about the llvm-commits mailing list