[PATCH] D27159: [ThreadPool] Simplify the interface

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 29 00:11:33 PST 2016


davide added a comment.

  [49/49] Running the LLVM regression tests
  Testing Time: 259.34s
    Expected Passes    : 18270
    Expected Failures  : 121
    Unsupported Tests  : 386

  $ grep ENABLE_THREADS CMakeCache.txt
  LIBCXXABI_ENABLE_THREADS:BOOL=OFF
  //\n   This option may only be set to OFF when LIBCXX_ENABLE_THREADS=OFF.
  LIBCXX_ENABLE_THREADS:BOOL=OFF
  LIBCXX_ENABLE_THREAD_UNSAFE_C_FUNCTIONS:BOOL=ON
  //\n   This option may only be set to ON when LIBCXX_ENABLE_THREADS=ON.
  LLVM_ENABLE_THREADS:BOOL=OFF



================
Comment at: unittests/Support/ThreadPool.cpp:102
   ASSERT_EQ(5, checked_in);
 }
 
----------------
mehdi_amini wrote:
> You need to make sure this works with LLVM_ENABLE_THREADS=OFF
I tried to run the testsuite with ENABLE_THREADS=OFF. Is there any other test you recommend to run or is this fine?


https://reviews.llvm.org/D27159





More information about the llvm-commits mailing list