[PATCH] D27182: [MachO] Add UnknownValueErrors and ability to ignore them.

[Kevin Enderby via Phabricator via llvm-commits]

enderby added inline comments.


================
Comment at: lib/Object/MachOObjectFile.cpp:1476-1477
     }
+    if (Err && !IgnoreValueErrs)
+      return;
   }
----------------
Seems like this bit of added logic will cause the loop over load commands to continue past all errors (even if the errors were not value errors) if IgnoreValueErrs is set and will not stop on the first error.  If that what you intended?  If so I'm not sure this code was written to be robust enough to handle this and not crash.  And I doubt there are single file cases with multiple errors that are tested.  Maybe you only wanted multiple value errors and not all multiple types of errors? 


https://reviews.llvm.org/D27182