[PATCH] D27184: Bitcode: Change expected layout of module blocks.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 28 18:27:08 PST 2016


mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

LGTM!
Thanks.



================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:2311
+      // before the start of the identification or module block, which was
+      // historically always the start of the file.
+      uint64_t FuncWordOffset = Record[1] - 1;
----------------
Is "historically always the start of the file" correct on Darwin?


https://reviews.llvm.org/D27184





More information about the llvm-commits mailing list