[PATCH] D26976: [AArch64] Fold spills of COPY of WZR/XZR

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 28 12:47:47 PST 2016


MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

I like solving the problem with the spill folding mechanism.
LGTM.



================
Comment at: lib/Target/AArch64/AArch64InstrInfo.cpp:2612
+  if (MI.isFullCopy() && Ops.size() == 1 && Ops[0] == 0) {
+    MachineBasicBlock *MBB = MI.getParent();
+    const MachineOperand &SrcMO = MI.getOperand(1);
----------------
I would use references instead of pointers for things that cannot be nullptr. Similar with `TRI, RC` below.


https://reviews.llvm.org/D26976





More information about the llvm-commits mailing list