[PATCH] D26419: Bug 30934 - YAML error not reported by ``yaml::Input::error()``

[Mehdi Amini via llvm-commits]

Doesn’t build for me right now:


In file included from /llvm-project/llvm/lib/Support/YAMLParser.cpp:14:
/llvm-project/llvm/include/llvm/Support/YAMLParser.h:78:69: error: no type named 'error_code' in namespace 'std'
  Stream(StringRef Input, SourceMgr &, bool ShowColors = true, std::error_code* EC = nullptr);
                                                               ~~~~~^
/llvm-project/llvm/include/llvm/Support/YAMLParser.h:80:81: error: no type named 'error_code' in namespace 'std'
  Stream(MemoryBufferRef InputBuffer, SourceMgr &, bool ShowColors = true, std::error_code* EC = nullptr);
                                                                           ~~~~~^
/llvm-project/llvm/lib/Support/YAMLParser.cpp:1736:9: error: out-of-line definition of 'Stream' does not match any declaration in 'llvm::yaml::Stream'
Stream::Stream(StringRef Input, SourceMgr &SM, bool ShowColors, std::error_code *EC)
        ^~~~~~
/llvm-project/llvm/lib/Support/YAMLParser.cpp:1739:9: error: out-of-line definition of 'Stream' does not match any declaration in 'llvm::yaml::Stream'
Stream::Stream(MemoryBufferRef InputBuffer, SourceMgr &SM, bool ShowColors, std::error_code *EC)
        ^~~~~~
4 errors generated.




> On Nov 28, 2016, at 2:54 AM, serge via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> serge-sans-paille updated this revision to Diff 79382.
> serge-sans-paille marked an inline comment as done.
> serge-sans-paille added a comment.
> 
> This patch seemsmore robust: when a subcomponent reports an error, it may set the parent error_code.
> 
> 
> Repository:
>  rL LLVM
> 
> https://reviews.llvm.org/D26419
> 
> Files:
>  include/llvm/Support/YAMLParser.h
>  lib/Support/YAMLParser.cpp
>  lib/Support/YAMLTraits.cpp
>  unittests/Support/YAMLIOTest.cpp
> 
> <D26419.79382.patch>