[PATCH] D26621: [AArch64] Refactor LSE support as feature separate from V8.1a support.

[Tim Northover via Phabricator via llvm-commits]

t.p.northover accepted this revision.
t.p.northover added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Target/AArch64/AArch64.td:39
+def FeatureLSE : SubtargetFeature<"lse", "HasLSE", "true",
+  "Enable ARMv8.1 LSE instructions">;
+
----------------
joelkevinjones wrote:
> rengolin wrote:
> > t.p.northover wrote:
> > > Can we expand "LSE" in the description here? I still can't actually think what it could mean.
> > Ditto.
> So line 39 should be:
>   "Enable ARMv8.1 atomic memory access Large System Extension (LSE) instructions">'
> or:
>   "Enable ARMv8.1 Large System Extension (LSE) atomic memory access instructions">'
> First, second, or something else?
I vaguely prefer the second (and dark blue, really closer to navy but not quite; with yellow spots), but either would be fine. No need to reupload a patch, the rest looks fine to me.


https://reviews.llvm.org/D26621