[PATCH] D26489: [GVN, OptDiag] Include the value that is forwarded in load elimination

Adam Nemet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 28 09:43:31 PST 2016


anemet added inline comments.


================
Comment at: lib/IR/DiagnosticInfo.cpp:190
+  } else if (auto *I = dyn_cast<Instruction>(V))
+    Val = I->getOpcodeName();
 }
----------------
hfinkel wrote:
> In the future, we should try harder here to use debug info to get a real name.
Added a FIXME about this.

Thanks for your review!


https://reviews.llvm.org/D26489





More information about the llvm-commits mailing list