[PATCH] D26889: [ELF] - Implemented -no-rosegment.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 28 01:47:41 PST 2016


George Rimar <grimar at accesssoftek.com> writes:

>>I think you should also change compareSectionsNonScript. We don't have
>>to reorder ro/rx sections. It should use the new config variable and
>>that variable should be set when a linker script has SECTIONS.
>
> There is a little problem with such approach:
> HasSections is set very late, during createFiles(), so not possible to use it earlier. I updated the patch to demonstrate.
> Probably would be better to check both NoRosegment + HasSections and do not introduce that new flag ?

But SingleRoRx is not used early, right. So whatever sets HasSections
can set SingleRoRx too.

Cheers,
Rafael


More information about the llvm-commits mailing list