[PATCH] D27145: Add "RPRED" mechanism for relocation predicates. (5% speedup for `ld.lld -O0`)

Joerg Sonnenberger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 27 06:20:44 PST 2016


joerg added a comment.

Your change is IMO a non-trivial uglification of the code and will only one shift at runtime. I'm not sure that justifies this complexity. I would expect it to be trivial to transform the suggested codegen change into a constexpr function with array argument to do the same (and include an assert about the value range of x where necessary.


https://reviews.llvm.org/D27145





More information about the llvm-commits mailing list