[PATCH] D26114: [AMDGPU] Allow hoisting of comparisons out of a loop and eliminate condition copies

Valery Pykhtin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 25 06:15:26 PST 2016


vpykhtin accepted this revision.
vpykhtin added a comment.
This revision is now accepted and ready to land.

LGTM.

Please add diff with full context (-U999999) next time :)



================
Comment at: lib/Target/AMDGPU/SILowerControlFlow.cpp:367
+
+  for (auto SrcOp : Def->explicit_operands())
+    if (SrcOp.isUse() && (!SrcOp.isReg() ||
----------------
I would use const auto &SrcOp to avoid MachineOperand copy.


Repository:
  rL LLVM

https://reviews.llvm.org/D26114





More information about the llvm-commits mailing list