[PATCH] D27040: [ELF] - Add support for access to most of synthetic sections from linkerscript.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/SyntheticSections.h:35
   virtual void finalize() {}
+  virtual bool isPresent() const { return true; }
 
----------------
grimar wrote:
> ruiu wrote:
> > `isPresent` sound a bit odd to me, because as soon as you instantiate objects, they are present. How about `empty`?
> Done.
Well, `empty` should return true if it is empty. Your functions return true if it is not empty.


https://reviews.llvm.org/D27040