[PATCH] D27094: [StringRef] Use default member initializers and = default.

Malcolm Parsons via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 24 04:32:15 PST 2016


malcolm.parsons created this revision.
malcolm.parsons added reviewers: zturner, beanz.
malcolm.parsons added a subscriber: llvm-commits.

This makes the default constructor implicitly constexpr and noexcept.


https://reviews.llvm.org/D27094

Files:
  include/llvm/Support/CommandLine.h


Index: include/llvm/Support/CommandLine.h
===================================================================
--- include/llvm/Support/CommandLine.h
+++ include/llvm/Support/CommandLine.h
@@ -179,8 +179,8 @@
 //
 class SubCommand {
 private:
-  StringRef Name = "";
-  StringRef Description = "";
+  StringRef Name;
+  StringRef Description;
 
 protected:
   void registerSubCommand();
@@ -304,8 +304,8 @@
                   enum OptionHidden Hidden)
       : NumOccurrences(0), Occurrences(OccurrencesFlag), Value(0),
         HiddenFlag(Hidden), Formatting(NormalFormatting), Misc(0), Position(0),
-        AdditionalVals(0), ArgStr(""), HelpStr(""), ValueStr(""),
-        Category(&GeneralCategory), FullyInitialized(false) {}
+        AdditionalVals(0), Category(&GeneralCategory), FullyInitialized(false) {
+  }
 
   inline void setNumAdditionalVals(unsigned n) { AdditionalVals = n; }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27094.79215.patch
Type: text/x-patch
Size: 894 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161124/9a62020c/attachment.bin>


More information about the llvm-commits mailing list