[PATCH] D27073: Object: Extract a ModuleSymbolTable class from IRObjectFile.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 23 21:27:18 PST 2016


mehdi_amini added inline comments.


================
Comment at: llvm/include/llvm/Object/ModuleSymbolTable.h:42
+  ArrayRef<Symbol> symbols() const { return SymTab; }
+  void addModule(Module *M);
+
----------------
Could it take a `MemoryBufferRef` and construct a lazy module that it would own? The fact that a Module is created should be an implementation detail.

That seems closer to the goal of having a symbol table in the bitcode file, and will help designing the client APIs appropriately.



https://reviews.llvm.org/D27073





More information about the llvm-commits mailing list