[PATCH] D26790: [X86] Add a hasOneUse check to selectScalarSSELoad to keep the same load from being folded multiple times

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 23 19:55:37 PST 2016


craig.topper added a comment.

Given the problem with the chain I don't think I can gate this on any optimization flag. I think we need this check to be consistent with the behavior that OPC_CheckFoldableChainNode has for normal load during isel. That check makes sure all nodes preceeding the load up to the root have a single use. So adding the check here would ensure the same behavior.


https://reviews.llvm.org/D26790





More information about the llvm-commits mailing list