[PATCH] D24956: [SelectionDAG] Add expansion and promotion of [US]MUL_LOHI

Nicolai Hähnle via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 23 13:15:06 PST 2016

nhaehnle added inline comments.

Comment at: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:3340
+    SmallVector<SDValue, 4> Halves;
+    EVT HalfType = EVT(VT).getHalfSizedIntegerVT(*DAG.getContext());
+    if (TLI.expandMUL_LOHI(Node->getOpcode(), VT, Node, LHS, RHS, Halves,
efriedma wrote:
> Maybe add an assertion here that HalfType is a legal type?  Some architectures could trip over this...
I missed this one, sorry.


More information about the llvm-commits mailing list