[PATCH] D27042: lld: Default image base address to 0x200000 on x86-64

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 23 08:14:39 PST 2016


rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/ELF/eh-frame-hdr.s:67
 //            FDE(1): 14000000 1C000000 880E0000 01000000 00000000 00000000
-//                    address of data (starts with 0x880E0000) = 0x10158 + 0x0020 = 0x10178
-//                    The starting address to which this FDE applies = 0xE88 + 0x10178 = 0x11000
+//                    address of data (starts with 0x880E0000) = 0x200158 + 0x0020 = 0x200178
+//                    The starting address to which this FDE applies = 0xE88 + 0x200178 = 0x201000
----------------
emaste wrote:
> Addresses in these comments need to be checked/updated
It is a pity "llvm-objdump -dwarf=frames" is broken :-(


================
Comment at: test/ELF/gotpc-relax-nopic.s:18-26
+# DISASM-NEXT:   201000:  48 81 d0 00 20 20 00  adcq  $2105344, %rax
+# DISASM-NEXT:   201007:  48 81 c3 00 20 20 00  addq  $2105344, %rbx
+# DISASM-NEXT:   20100e:  48 81 e1 00 20 20 00  andq  $2105344, %rcx
+# DISASM-NEXT:   201015:  48 81 fa 00 20 20 00  cmpq  $2105344, %rdx
+# DISASM-NEXT:   20101c:  48 81 cf 00 20 20 00  orq   $2105344, %rdi
+# DISASM-NEXT:   201023:  48 81 de 00 20 20 00  sbbq  $2105344, %rsi
+# DISASM-NEXT:   20102a:  48 81 ed 00 20 20 00  subq  $2105344, %rbp
----------------
emaste wrote:
> Should I switch these to `{{.*}}`
Yes please.


================
Comment at: test/ELF/no-inhibit-exec.s:9
 # CHECK-NEXT: _start
-# CHECK-NEXT: 11000:   e8 fb ef fe ff callq -69637
+# CHECK-NEXT: 201000:    e8 fb ef df ff callq -2101253
 
----------------
emaste wrote:
> `{{.*}}` ?
Yes


================
Comment at: test/ELF/relocation-copy.s:62-67
+// CODE-NEXT: 201000: c7 04 25 00 30 20 00 05 00 00 00 movl $5, 2109440
+// CODE-NEXT: 20100b: c7 04 25 10 30 20 00 07 00 00 00 movl $7, 2109456
+// CODE-NEXT: 201016: c7 04 25 14 30 20 00 09 00 00 00 movl $9, 2109460
+// CODE-NEXT: 201021: ba 00 30 20 00                   movl $2109440, %edx
+// CODE-NEXT: 201026: ba 10 30 20 00                   movl $2109456, %edx
+// CODE-NEXT: 20102b: ba 14 30 20 00                   movl $2109460, %edx
----------------
emaste wrote:
> `{{.*}}` ?
Yes.


https://reviews.llvm.org/D27042





More information about the llvm-commits mailing list