[PATCH] D26521: [X86] Allow folding of reloads from stack slots when loading a subreg of the spilled reg

[Matthias Braun via llvm-commits]

MatzeB added a comment.

In https://reviews.llvm.org/D26521#603450, @mkuper wrote:

> In https://reviews.llvm.org/D26521#603360, @MatzeB wrote:
>
> > What about changing `isSubregFoldable()` to not take any parameters and just return true/false, so all the decision logic can stay in `foldMemoryOperand()`?
>
>
> Do you mean in the target's foldMemoryOperandImpl()? (The decision needs to be target-dependent)
>  If you do, I think that can work. Not sure it's going to be a net improvement, but I'll post a patch.


Yep, I would expect that to make the code (slightly) easier to follow as the logic is not split accross two callbacks anymore.


https://reviews.llvm.org/D26521