[PATCH] D26951: Object: Make IRObjectFile own multiple modules and enumerate symbols from all modules.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 22 16:13:22 PST 2016


pcc added a comment.

In https://reviews.llvm.org/D26951#603478, @mehdi_amini wrote:

> Right, but the "triple" as a discriminator seems arbitrary to me: what about use cases where we ship a "fat" object file containing bitcode for a non-optimized debug build of the module and an optimized one?  Or for building with and without options like freestanding? Or with and without the sanitizers?


I think we're confusing a couple of things here. I am not saying that the triple would be the discriminator; the discriminator could in principle be anything the client wants (and could be chosen at BitcodeWriter time). The reason I mentioned that modules associated with a single ModuleSymbolTable should have the same triple is to ensure that the eventual object files are compatible and that name mangling happens consistently. I am not precluding having multiple ModuleSymbolTables whose modules happen to have the same target triple.


https://reviews.llvm.org/D26951





More information about the llvm-commits mailing list