[PATCH] D26999: Add some functions to search ArrayRefs

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 22 15:13:41 PST 2016


chandlerc added a comment.

I would suggest passing the predicate by value instead of const reference to match the standard library. Feel free to fix up the range adapters in a separate patch and systematically.

Also, I'd suggest 'typename PredicateT' and 'PredicateT P' for naming conventions, if you want to be fully nit-picky. =D


https://reviews.llvm.org/D26999





More information about the llvm-commits mailing list