[PATCH] D26632: [sanitizer] Track architecture and UUID of modules in LoadedModule

[Kuba Brecka via llvm-commits]

kubabrecka updated this revision to Diff 78920.
kubabrecka added a comment.

Updating patch.

> Should we assert that we always find a UUID?

No, I don't think so.  The linker emits a LC_UUID load command by default, but you can suppress this with `-no_uuid`.  Not sure why you'd ever want to do that, but a Mach-O is valid even without a UUID.

> Are the unit tests only run on X86(-64)? Never on ARM?

That's currently correct:  On Darwin we can only run unit tests locally on the machine that builds compiler-rt, and I'm not sure but I think the same holds for Linux as well.


https://reviews.llvm.org/D26632

Files:
  lib/sanitizer_common/sanitizer_common.cc
  lib/sanitizer_common/sanitizer_common.h
  lib/sanitizer_common/sanitizer_procmaps.h
  lib/sanitizer_common/sanitizer_procmaps_freebsd.cc
  lib/sanitizer_common/sanitizer_procmaps_linux.cc
  lib/sanitizer_common/sanitizer_procmaps_mac.cc
  lib/sanitizer_common/tests/sanitizer_procmaps_test.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26632.78920.patch
Type: text/x-patch
Size: 12324 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161122/916fb790/attachment.bin>