[PATCH] D25136: [Triple] Add Facebook vendor

[Daniel Berlin via llvm-commits]

This is not okay. You need to respond to objections *before* you commit.
Please revert.

On Tue, Nov 22, 2016, 11:47 AM Shoaib Meenai <smeenai at fb.com> wrote:

> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL287684: [Triple] Add Facebook vendor (authored by
> smeenai).
>
> Changed prior to commit:
>   https://reviews.llvm.org/D25136?vs=73153&id=78910#toc
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D25136
>
> Files:
>   llvm/trunk/include/llvm/ADT/Triple.h
>   llvm/trunk/lib/Support/Triple.cpp
>
>
> Index: llvm/trunk/include/llvm/ADT/Triple.h
> ===================================================================
> --- llvm/trunk/include/llvm/ADT/Triple.h
> +++ llvm/trunk/include/llvm/ADT/Triple.h
> @@ -130,6 +130,7 @@
>      SCEI,
>      BGP,
>      BGQ,
> +    Facebook,
>      Freescale,
>      IBM,
>      ImaginationTechnologies,
> Index: llvm/trunk/lib/Support/Triple.cpp
> ===================================================================
> --- llvm/trunk/lib/Support/Triple.cpp
> +++ llvm/trunk/lib/Support/Triple.cpp
> @@ -152,6 +152,7 @@
>    case SCEI: return "scei";
>    case BGP: return "bgp";
>    case BGQ: return "bgq";
> +  case Facebook: return "facebook";
>    case Freescale: return "fsl";
>    case IBM: return "ibm";
>    case ImaginationTechnologies: return "img";
> @@ -434,6 +435,7 @@
>      .Case("scei", Triple::SCEI)
>      .Case("bgp", Triple::BGP)
>      .Case("bgq", Triple::BGQ)
> +    .Case("facebook", Triple::Facebook)
>      .Case("fsl", Triple::Freescale)
>      .Case("ibm", Triple::IBM)
>      .Case("img", Triple::ImaginationTechnologies)
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161122/f7b8730a/attachment.html>