[PATCH] D26879: Make a DwarfGen class that can generate DWARF for unittests and add units tests to test DWARF API.

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 22 11:42:21 PST 2016


dblaikie added a comment.

I think it would be easier to follow if it were split up a bit more (but perhaps others who can review (Adrian et al) don't mind so much) - seems like there's at least 3 bits in here: move fields out of DwarfDebug (some of that's just refactoring, as you did in the last update), generalize support and use it in DwarfLinker to remove the special case, then add the unit test wrapper on top of the now generalized API.


https://reviews.llvm.org/D26879





More information about the llvm-commits mailing list