[PATCH] D26935: [ELF] Allow `ASSERT` in output section descriptions

[Rui Ueyama via llvm-commits]

ruiu added inline comments.


================
Comment at: test/ELF/linkerscript/assert.s:33-38
+# RUN: echo "SECTIONS {                         \
+# RUN:   .foo : {                               \
+# RUN:     *(.foo)                              \
+# RUN:     ASSERT(SIZEOF(.foo) == 8, \"true\"); \
+# RUN:   }                                      \
+# RUN: }" > %t6.script
----------------
meadori wrote:
> ruiu wrote:
> > Can you write this in one line? Look at other tests in this file.
> Sure.  I noticed the recent changes to the tests in this file and changed the test following this one to be on one line.  I left this one alone b/c it was a bit longer.  Is it OK to exceed 80 columns?
I'd make it one line even if it exceeds 80 columns a bit. Because otherwise an error message for this test would be really hard to read. It becomes something like this as it contains lots of spaces.

  error: foo1.o:1: SECTIONS { <lots of spaces> .foo { <lots of spaces> ASSERT(...) <lots of spaces> ...
  error: foo1.o:1:                                   <lots of spaces> ^ error here

That's why I changed other tests.


https://reviews.llvm.org/D26935