[PATCH] D26935: [ELF] Allow `ASSERT` in output section descriptions

Meador Inge via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 22 09:02:57 PST 2016


meadori added inline comments.


================
Comment at: test/ELF/linkerscript/assert.s:33-38
+# RUN: echo "SECTIONS {                         \
+# RUN:   .foo : {                               \
+# RUN:     *(.foo)                              \
+# RUN:     ASSERT(SIZEOF(.foo) == 8, \"true\"); \
+# RUN:   }                                      \
+# RUN: }" > %t6.script
----------------
ruiu wrote:
> Can you write this in one line? Look at other tests in this file.
Sure.  I noticed the recent changes to the tests in this file and changed the test following this one to be on one line.  I left this one alone b/c it was a bit longer.  Is it OK to exceed 80 columns?


https://reviews.llvm.org/D26935





More information about the llvm-commits mailing list