[PATCH] D26832: [LTO] Add option to generate optimization records

Adam Nemet via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 21 22:34:49 PST 2016


anemet added inline comments.


================
Comment at: llvm/trunk/lib/LTO/LTOCodeGenerator.cpp:570
 
+  finishOptimizationRemarks();
+
----------------
mehdi_amini wrote:
> Actually there is an issue with this code: the backend can also emit remarks, but they may not be in the file, or the file be truncated because you flushed early but not after the backend it complete.
So I guess we need to call this in compileOptimized.  I'll take a look after the Thanksgiving break.


Repository:
  rL LLVM

https://reviews.llvm.org/D26832





More information about the llvm-commits mailing list