[PATCH] D21731: fix bug 15393: invalid dwarf info on Win64

[David Majnemer via llvm-commits]

majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.

LGTM with nits addressed.



================
Comment at: lib/MC/MCAsmStreamer.cpp:621
+  if (Offset != 0) {
+      OS << '+' << Offset;
+  }
----------------
Please format this appropriately.


================
Comment at: lib/MC/MCParser/COFFAsmParser.cpp:469-473
+  if (Offset < 0)
+    return Error(OffsetLoc, "invalid '.secrel32' directive offset, can't be less"
+                 "than zero");
+
+
----------------
Please include a check for `< UINT32_MAX`.


================
Comment at: lib/MC/WinCOFFStreamer.cpp:202
+  const MCExpr *MCE = MCSymbolRefExpr::create(Symbol, getContext());
+  // Add the constant offset, if given
+  if (Offset)
----------------
Comments end with a period.


Repository:
  rL LLVM

https://reviews.llvm.org/D21731