[PATCH] D26948: TargetSubtargetInfo: Move implementation to lib/CodeGen; NFC

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 21 18:19:12 PST 2016


MatzeB added a comment.

In https://reviews.llvm.org/D26948#602134, @chandlerc wrote:

> If you want to do this, we should really move the header as well. We shouldn't have classes with headers in Target and implementation in CodeGen.
>
> However, I suspect that will present more problems... =/


Well
include/llvm/Target/TargetRegisterInfo.h
include/llvm/Target/TargetFrameLowering.h
include/llvm/Target/TargetInstrInfo.h
...
are all implemented in lib/CodeGen as well, so I thought I stay consistent (even though it is silly).


Repository:
  rL LLVM

https://reviews.llvm.org/D26948





More information about the llvm-commits mailing list