[PATCH] D26594: IR: Change the gep_type_iterator API to avoid always exposing the "current" type.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 21 15:53:41 PST 2016


pcc added a comment.

I think we could in principle continue to provide a way to access the "current type", but it would make the gep_type_iterator implementation even harder to follow once we move PointerType (for example, we would probably have to add type switches in the two places where we have CompositeType::getTypeAtIndex now). gep_type_iterator was already getting rather complicated as a result of supporting operator* (e.g. it takes an address space) and I would prefer not to add to that.


https://reviews.llvm.org/D26594





More information about the llvm-commits mailing list