[PATCH] D26130: [ELF] - Implemented --symbol-ordering-file option.

[Rui Ueyama via llvm-commits]

I don't think it's proved to work. It might need improving until we provide
it to the public.

In particular, I'm worried that this feature could produce unexpected
section ordering, because it reorders local symbols. Local symbols are not
guaranteed to be unique, so a symbol in a symbol ordering file could
accidentally matches with an unintended symbol and reorders sections
wrongly. gold's --section-ordering-file might be half-baked, but this
--symbol-orderfing-file might be half-baked, too.

More importantly, I think my point is that we should have had this kind of
discussion based on a proposal before landing a feature.

On Mon, Nov 21, 2016 at 10:43 AM, Davide Italiano <dccitaliano at gmail.com>
wrote:

> On Mon, Nov 21, 2016 at 9:52 AM, Rui Ueyama <ruiu at google.com> wrote:
> > Sure, but do you have a plan to start using it? Once it is out in the
> next
> > release, we'll have to keep it like forever. We take too much risk it
> > doesn't have actual users.
> >
>
> We have plans to use at least internally. Every consumer of gold using
> --section-ordering-file can pretty much easily migrate to
> --symbol-ordering file without a lot of hassle. I don't expect many
> people relying on this feature.
>
> --
> Davide
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161121/f3e5f024/attachment.html>