[PATCH] D26880: [ThinLTO] Fix crash: transitively referenced global shouldn't be promoted

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 21 14:11:14 PST 2016


mehdi_amini added a comment.

Correct: this optimization is incorrect as is, and not tested, which seems a good reason to remove it :)
How to recover the optimization is open to discussion though: it seems that we agree on the right thing to do, but you also seem to target a temporary patch along the same line of what I'm removing here. I'm not opposed to the latter, but writing a correct and tested patch to have this optimization seems independent from fixing the correctness issue in the first place.


https://reviews.llvm.org/D26880





More information about the llvm-commits mailing list