[PATCH] D26851: [SelectionDAG] ComputeNumSignBits of TRUNCATE operations

[Eli Friedman via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:2833
+    if (Tmp2 > (Tmp - VTBits))
+      return Tmp2 - (Tmp - VTBits);
     break;
----------------
RKSimon wrote:
> efriedma wrote:
> > Please use variable names which are not "Tmp" and "Tmp2".
> No problem - but these are the default variables that are already used in most of the other cases.
It probably isn't a good idea for the other cases. :)


Repository:
  rL LLVM

https://reviews.llvm.org/D26851