[PATCH] D23652: [mips] N64 static relocation model support

Sean Bruno via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 21 13:36:08 PST 2016


seanbruno added a comment.

I get one reject with this review that I'm unsure how to resolve at the moment

  % cat ./lib/Target/Mips/MipsISelLowering.cpp.rej
  @@ -1699,7 +1702,7 @@
         MachinePointerInfo::getJumpTable(DAG.getMachineFunction()), MemVT);
     Chain = Addr.getValue(1);
  
  -  if (isPositionIndependent() || ABI.IsN64()) {
  +  if (isPositionIndependent()) {
       // For PIC, the sequence is:
       // BRIND(load(Jumptable + index) + RelocBase)
       // RelocBase can be JumpTable, GOT or some sort of global base.


https://reviews.llvm.org/D23652





More information about the llvm-commits mailing list