[PATCH] D26919: Update document. It is not an overstatement that LLD is 2x faster than gold.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 21 11:41:32 PST 2016


ruiu added inline comments.


================
Comment at: docs/NewLLD.rst:14
 you can expect it to be linkable with LLD.
-It is currently about 1.2x to 2x faster than GNU gold linker.
+It is about 2x faster than GNU gold linker.
 We aim to make it a drop-in replacement for the GNU linker.
----------------
davide wrote:
> davide wrote:
> > emaste wrote:
> > > davide wrote:
> > > > This is a strong claim. I'd rather leave the comment as is or rephrase as "it is generally faster than gold". If you really want to show the figures, well, maybe, we can add a section with some charts updated periodically (at each release), but I would refrain from making the statement so general.
> > > Perhaps we can get an updated version of @rafael's and @davide's BSDCan benchmark results, and reference specific results?
> > Yes, that would do it. I think it's much better showing real numbers =)
> To clarify, I had in mind something like this http://www.dragonflybsd.org/performance/ but for link times.
I agree that a graph would be better than the number. I don't think saying we are about 2x faster is a bad thing, we can change the tone to make it sound not too strong, but a graph would be more convincing.


https://reviews.llvm.org/D26919





More information about the llvm-commits mailing list