[PATCH] D19493: AMDGPU/SI: Add pass for promoting uniform loads to constant address space

[Stanislav Mekhanoshin via llvm-commits]

rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/GCNOptimizeUniformMemOps.cpp:105
+    Type *NewTy = PointerType::get(ElTy,
+                                   AMDGPUAS::CONSTANT_ADDRESS);
+    // FIXME: Add update methods to divergence analysis and update it here.
----------------
According to memory model global and constant do not alias. Casts are only possible between flat and any non-constant segment.


https://reviews.llvm.org/D19493